Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add informers to client-go #41340

Merged
merged 3 commits into from
Feb 14, 2017
Merged

Add informers to client-go #41340

merged 3 commits into from
Feb 14, 2017

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Feb 13, 2017

Adds informers and listers to client-go so that you can build a controller on it.

@sttts @caesarxuchao @kubernetes/sig-api-machinery-misc

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 13, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

The following people have approved this PR: deads2k

Needs approval from an approver in each of these OWNERS Files:

We suggest the following people:
cc @lavalamp
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-label-needed labels Feb 13, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@deads2k deads2k added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2017
@deads2k
Copy link
Contributor Author

deads2k commented Feb 13, 2017

It's the vendor/BUILD file again. marking approved.

@ncdc ncdc self-assigned this Feb 13, 2017
@ncdc
Copy link
Member

ncdc commented Feb 13, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Feb 13, 2017
@ncdc ncdc added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 13, 2017
@ncdc
Copy link
Member

ncdc commented Feb 13, 2017

/lgtm

@deads2k deads2k removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Feb 13, 2017
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 13, 2017
@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 13, 2017
@deads2k deads2k added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 13, 2017
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 13, 2017 •
edited

@deads2k: The following test(s) failed:

Test name Commit Details Rerun command
Jenkins Cross Build f2b27c4 link @k8s-bot cross build this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 41115, 41212, 41346, 41340, 41172)

k8s-github-robot pushed a commit that referenced this pull request Feb 14, 2017
Merge pull request #41340 from deads2k/client-02-add-informers
fa5a2fe 
Automatic merge from submit-queue (batch tested with PRs 41115, 41212, 41346, 41340, 41172)

Add informers to client-go

Adds informers and listers to client-go so that you can build a controller on it. 

@sttts @caesarxuchao @kubernetes/sig-api-machinery-misc
@k8s-github-robot k8s-github-robot merged commit fa5a2fe into kubernetes:master Feb 14, 2017
@caesarxuchao caesarxuchao mentioned this pull request Feb 16, 2017
Closed
@deads2k deads2k deleted the client-02-add-informers branch March 7, 2017 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ncdc ncdc

@sttts sttts

@caesarxuchao caesarxuchao

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@deads2k @k8s-github-robot @k8s-reviewable @ncdc @k8s-ci-robot @sttts @caesarxuchao